Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hls): Support AES-128 in HLS #4386

Merged
merged 4 commits into from
Aug 12, 2022
Merged

feat(hls): Support AES-128 in HLS #4386

merged 4 commits into from
Aug 12, 2022

Conversation

theodab
Copy link
Contributor

@theodab theodab commented Aug 3, 2022 •
edited by avelad
Loading

Expands on the original PR (#3880) by adding support for MP4 and key rotation.

Close #850

Co-authored-by: wjywbs [email protected]

@theodab
feat(hls): Support AES-128 in HLS
235f587 
Also adds support for key rotation in HLS, but only for AES-128.

Based on shaka-project#3880
Issue shaka-project#850
@theodab theodab added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format labels Aug 3, 2022
avelad
avelad reviewed Aug 3, 2022
View reviewed changes
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
@theodab theodab mentioned this pull request Aug 3, 2022
Closed
11 tasks
joeyparrish
joeyparrish requested changes Aug 5, 2022
View reviewed changes
externs/shaka/manifest.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/media/segment_reference.js Outdated Show resolved Hide resolved
lib/media/segment_reference.js Outdated Show resolved Hide resolved
lib/media/streaming_engine.js Outdated Show resolved Hide resolved
lib/media/streaming_engine.js Show resolved Hide resolved
@avelad avelad mentioned this pull request Aug 11, 2022
Closed
avelad
avelad reviewed Aug 12, 2022
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
joeyparrish
joeyparrish approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joeyparrish joeyparrish merged commit 6194021 into shaka-project:main Aug 12, 2022
@github-actions github-actions bot mentioned this pull request Aug 12, 2022
Merged
joeyparrish pushed a commit to joeyparrish/shaka-player that referenced this pull request Aug 13, 2022
@theodab @wjywbs @joeyparrish
feat(hls): Support AES-128 in HLS (shaka-project#4386)
36e4411 
Expands on the original PR (shaka-project#3880) by adding support for MP4 and key rotation.

Close shaka-project#850

Co-authored-by: wjywbs <[email protected]>
@theodab theodab deleted the aes128 branch August 15, 2022 17:47
@joeyparrish joeyparrish mentioned this pull request Aug 18, 2022
Closed
echoy-harmonicinc pushed a commit to harmonicinc-com/shaka-player that referenced this pull request Dec 6, 2022
@theodab @wjywbs @echoy-harmonicinc
feat(hls): Support AES-128 in HLS (shaka-project#4386)
248a98b 
Expands on the original PR (shaka-project#3880) by adding support for MP4 and key rotation.

Close shaka-project#850

Co-authored-by: wjywbs <[email protected]>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad left review comments

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AES-128 on HLS
3 participants
@theodab @joeyparrish @avelad